Skip to content

[DataFactory]Add AzureFileStorage and GoogleCloudStorage#7308

Merged
lirenhe merged 1 commit intoAzure:masterfrom
wenbof-zz:master
Sep 29, 2019
Merged

[DataFactory]Add AzureFileStorage and GoogleCloudStorage#7308
lirenhe merged 1 commit intoAzure:masterfrom
wenbof-zz:master

Conversation

@wenbof-zz
Copy link
Copy Markdown

@wenbof-zz wenbof-zz commented Sep 25, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Sep 25, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from bba298e, Iteration 1)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed datafactory/resource-manager/v2017_09_01_preview [Logs] [Generation PR]
  • Failed datafactory/resource-manager/v2018_06_01 [Logs]
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress datafactory/mgmt/2018-06-01 [Logs]
  • In-Progress preview/datafactory/mgmt/2017-09-01-preview [Logs]
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.

@wenbof-zz wenbof-zz mentioned this pull request Sep 25, 2019
Closed
@wenbof-zz
Copy link
Copy Markdown
Author

wenbof-zz commented Sep 25, 2019

related SDK: Azure/azure-sdk-for-net#7752

@AutorestCI AutorestCI mentioned this pull request Sep 25, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 25, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7481

@AutorestCI AutorestCI mentioned this pull request Sep 25, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 25, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5918

This was referenced Sep 25, 2019
Closed
Closed
@azuresdkci azuresdkci requested a review from lirenhe September 25, 2019 05:10
@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Sep 25, 2019

Can one of the admins verify this patch?

@lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 25, 2019
@ravbhatnagar
Copy link
Copy Markdown
Contributor

ravbhatnagar commented Sep 28, 2019

Adding new writable properties is a breaking change and must be done in a new api-version. But we have given exception to datafactory RP due to certain reasons around service behavior and end customer use case. Hence signing off on this.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 28, 2019
@lirenhe lirenhe merged commit d901268 into Azure:master Sep 29, 2019
This was referenced Sep 29, 2019
Merged
Merged
@wenbof-zz wenbof-zz mentioned this pull request Sep 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lirenhe lirenhe lirenhe approved these changes

Assignees

@lirenhe lirenhe

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wenbof-zz @AutorestCI @azuresdkci @ravbhatnagar @lirenhe @wenbof